Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cesiumGeometryToGltfPrimitive does not generate unique accessor names #321

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Fixed cesiumGeometryToGltfPrimitive does not generate unique accessor names #321

merged 1 commit into from
Sep 27, 2017

Conversation

shehzan10
Copy link
Member

Added spec in geometryNormals so that when smoothNormals are generated
with mesh with 2 primitives, this does not generate duplicate accessors.

var byteLengthBefore = 432;
generateNormals(gltf);

console.log(gltf.meshes);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove log.

@lilleyse
Copy link
Contributor

Update CHANGES.md

@lilleyse
Copy link
Contributor

There is an eslint error:

C:\Code\gltf-pipeline\specs\lib\generateNormalsSpec.js
  10:5  error  'boxahedronNormalsGltfPath' is assigned a value but never used  no-unused-vars

… names

Added spec in geometryNormals so that when smoothNormals are generated
with mesh with 2 primitives, this does not generate duplicate accessors.
@lilleyse lilleyse merged commit 768a0d7 into CesiumGS:master Sep 27, 2017
@shehzan10 shehzan10 deleted the duplicate-accessors-fix branch November 30, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants